Skip to content

Add comment-format converter #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 21, 2019
Merged

Add comment-format converter #240

merged 4 commits into from
Oct 21, 2019

Conversation

KingDarBoja
Copy link
Collaborator

PR Checklist

Overview

Add missing comment-format converter as already being listed at ROADMAP

JoshuaKGoldberg
JoshuaKGoldberg requested changes Oct 19, 2019
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly 💯! I think just the hasCheckTrailingLowercase/ignoreConsecutiveComments request is the only behavior change, with a couple of smaller things.

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author The PR author should address requested changes label Oct 19, 2019
@JoshuaKGoldberg JoshuaKGoldberg added status: waiting for reviewer Waiting for a maintainer to review and removed status: waiting for author The PR author should address requested changes labels Oct 20, 2019
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 20, 2019
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. If there's a way to close the gap on single vs. many regexp ignore patterns, I'm ok with not looking at them until & unless someone files a followup issue... seems hairy.

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Oct 20, 2019 •
edited
Loading

Just waiting on the test task to be fixed - missing coverage on line 32 of comment-format.ts. 👍

@JoshuaKGoldberg JoshuaKGoldberg added status: waiting for author The PR author should address requested changes and removed status: waiting for reviewer Waiting for a maintainer to review labels Oct 20, 2019
@KingDarBoja
Copy link
Collaborator Author

Just waiting on the test task to be fixed - missing coverage on line 32 of comment-format.ts. 👍

I already covered that line but not sure why the test coverage is saying it doesn't 😢

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for reviewer Waiting for a maintainer to review label Oct 20, 2019
@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Oct 20, 2019 •
edited
Loading

Ahh, it's partially covered. Branch coverage is <100% so although the line is hit, not every case in it is. Expanding in file:///C:/Code/tslint-to-eslint-config/coverage/lcov-report/src/rules/converters/comment-format.ts.html (or whatever your file path equivalent would be):

screenshot of comment-format.ts.html, with the 'else' hovered and indicating a missed branch

I think the missing case is objectArgument["ignore-words"].length being 0?

@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for reviewer Waiting for a maintainer to review label Oct 20, 2019
@KingDarBoja
Copy link
Collaborator Author

@JoshuaKGoldberg Good catch! Now it is ready 🍰

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 21, 2019
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet. Thanks as always @KingDarBoja!

@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for author The PR author should address requested changes label Oct 21, 2019
@JoshuaKGoldberg JoshuaKGoldberg merged commit 325789d into typescript-eslint:master Oct 21, 2019
@KingDarBoja KingDarBoja deleted the feature/comment-format-converter branch October 21, 2019 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KingDarBoja @JoshuaKGoldberg